Re: [libvirt] [PATCH 04/25] m4: virt-selinux: remove obsolete checks

On Mon, Oct 21, 2019 at 10:00:29AM +0200, Pavel Hrdina wrote: > All OSes that we support have libselinux >= 2.5 except for Ubuntu 16.04 > where the version is 2.4. > > Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com&gt; > --- > m4/virt-selinux.m4 | 20 ++------------------ > src/qemu/qemu_domain.c | 4 ++-- > src/security/security_selinux.c | 22 ++-------------------- > tests/securityselinuxhelper.c | 19 +++++-------------- > 4 files changed, 11 insertions(+), 54 deletions(-) > > diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c > index a97bf65e7f..71478319a6 100644 > --- a/src/qemu/qemu_domain.c > +++ b/src/qemu/qemu_domain.c > @@ -13262,7 +13262,7 @@ qemuDomainCreateDeviceRecursive(const char *device, > } > > if (tcon && > - lsetfilecon_raw(devicePath, (VIR_SELINUX_CTX_CONST char *)tcon) < 0) { > + lsetfilecon_raw(devicePath, (const char *)tcon) < 0) { I'm confused - why do we use a cast here in the first place? The original failure was that the definition of our mocked versions of the APIs did not match the declaration in system selinux headers: https://www.redhat.com/archives/libvir-list/2014-May/msg00925.html Passing char* to a function treating it as const char* is allowed and I don't see any benefit of explicitly casting it.