Re: [PATCH] qemu: Replace the deprecated short-formed option "unix"
On 12/21/23 13:30, Ján Tomko wrote:
On a Thursday in 2023, Michal Prívozník wrote:
> On 12/21/23 09:33, Han Han wrote:
>> Change to the boolean option "unix=on"
>>
>> Signed-off-by: Han Han <hhan(a)redhat.com>
>> ---
>
> And just for next time: please do insert a link to corresponding gitlab
> issue. For instance:
>
> Change the boolean option "unix=on".
>
> Resolves: https://gitlab.com/libvirt/libvirt/-/issues/573
> Signed-off-by: ....
>
> This has two advantages:
>
> 1) We know there is an issue associated (and perhaps can find more info,
> though in this case it's pretty obvious),
>
I was not aware there was an issue filed for this, otherwise I would
have included the link.
> 2) gitlab SHOULD close the issue automatically once the commit is
> merged, though this feature it broken for some time:
>
> https://gitlab.com/gitlab-org/gitlab/-/issues/389801
'Fixes:' works for auto-closing. If you don't want to mislead the reader
and instead want to close the issue with a commit that does not
necessarily fix the issue, 'Closes:' also works.
Yes, there are several options, either of which should close the issue [1].
From my experience, 'Closes' is usually used with MRs. And we tend to use
'Fixes' with reference to other commits that broke something.
1:
https://docs.gitlab.com/ee/user/project/issues/managing_issues.html#closi...
Michal