On Wed, Apr 09, 2008 at 02:38:34PM -0500, Eunice Moon wrote:
static vshCmdDef commands[] = { {"help", cmdHelp, opts_help, info_help}, +#ifndef WITH_LDOMS {"attach-device", cmdAttachDevice, opts_attach_device, info_attach_device}, You shouldn't need to comment out unsupported commands. They will return an error if they aren't supported. In fact, QEMU, KVM and OpenVZ only support a subset of the available operations.
OK. I will remove all these #ifdef WITH_LDOMS here.
I'd personally strongly prefer:
However if you want to propose a more general patch which allows virsh to determine which operations are supported on the current connection, then I'm all for it. Some of the infrastructure is in place to do this already.
It's particularly unfriendly to the user to have a whole bunch of apparent commands that actually don't work. (I'd also note that your PSARC case was approved with the commands not available.) regards john