Re: [PATCH 2/2] qemu-img: Require -F with -b backing image
On 5/3/21 4:45 PM, Eric Blake wrote:
On 5/3/21 4:36 PM, Eric Blake wrote:
> Back in commit d9f059aa6c (qemu-img: Deprecate use of -b without -F),
> we deprecated the ability to create a file with a backing image that
> requires qemu to perform format probing. Qemu can still probe older
> files for backwards compatibility, but it is time to finish off the
> ability to create such images, due to the potential security risk they
> present. Update a couple of iotests affected by the change.
>
> Signed-off-by: Eric Blake <eblake(a)redhat.com>
> ---
> docs/system/deprecated.rst | 20 -----------------
> docs/system/removed-features.rst | 19 ++++++++++++++++
> block.c | 37 ++++++++++----------------------
> qemu-img.c | 6 ++++--
> tests/qemu-iotests/114 | 18 ++++++++--------
> tests/qemu-iotests/114.out | 11 ++++------
> tests/qemu-iotests/301 | 4 +---
> tests/qemu-iotests/301.out | 16 ++------------
> 8 files changed, 50 insertions(+), 81 deletions(-)
I'll need a followup to fix iotest failures in 40 and 41 (apparently
they weren't passing backing formats, but I did not catch them in my
original cleanup of iotests back in commit b66ff2c298)
Squash in:
diff --git i/tests/qemu-iotests/040 w/tests/qemu-iotests/040
index ba7cb34ce8cf..f3677de9dfde 100755
--- i/tests/qemu-iotests/040
+++ w/tests/qemu-iotests/040
@@ -920,8 +920,8 @@ class
TestCommitWithOverriddenBacking(iotests.QMPTestCase):
def setUp(self):
qemu_img('create', '-f', iotests.imgfmt, self.img_base_a,
'1M')
qemu_img('create', '-f', iotests.imgfmt, self.img_base_b,
'1M')
- qemu_img('create', '-f', iotests.imgfmt, '-b',
self.img_base_a, \
- self.img_top)
+ qemu_img('create', '-f', iotests.imgfmt, '-b',
self.img_base_a,
+ '-F', iotests.imgfmt, self.img_top)
self.vm = iotests.VM()
self.vm.launch()
diff --git i/tests/qemu-iotests/041 w/tests/qemu-iotests/041
index 5cc02b24fc7a..db9f5dc540e8 100755
--- i/tests/qemu-iotests/041
+++ w/tests/qemu-iotests/041
@@ -1295,8 +1295,10 @@ class TestReplaces(iotests.QMPTestCase):
class TestFilters(iotests.QMPTestCase):
def setUp(self):
qemu_img('create', '-f', iotests.imgfmt, backing_img,
'1M')
- qemu_img('create', '-f', iotests.imgfmt, '-b',
backing_img,
test_img)
- qemu_img('create', '-f', iotests.imgfmt, '-b',
backing_img,
target_img)
+ qemu_img('create', '-f', iotests.imgfmt, '-b',
backing_img,
+ '-F', iotests.imgfmt, test_img)
+ qemu_img('create', '-f', iotests.imgfmt, '-b',
backing_img,
+ '-F', iotests.imgfmt, target_img)
qemu_io('-c', 'write -P 1 0 512k', backing_img)
qemu_io('-c', 'write -P 2 512k 512k', test_img)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org