Re: [libvirt] [PATCH 02/11] build: drop the getopt-posix gnulib module

3 Oct 2019


      On Thu, Oct 03, 2019 at 02:53:09PM +0100, Daniel P. Berrangé wrote:
...
The getopt-posix module fixes a problem with optind being incorrectly
set after a failed option parse. This is not something that matters to
libvirt code.
This module was introduced by:

commit b436a8ae5ccb04f8cf893d882d52ab5efc713307
    gnulib: add getopt module

for the patches implementing command line parsing for the bhyve
driver. So you can also remove the gl_REPLACE_GETOPT_ALWAYS definition
in m4/virt-driver-bhyve.m4 and delete gnulib/lib/getopt.c from
POTFILES.in.
...
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
bootstrap.conf | 1 -
po/POTFILES    | 1 -
2 files changed, 2 deletions(-)
Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano