On Mon, Jun 15, 2020 at 02:46:42PM +0200, Michal Privoznik wrote:
On 6/15/20 2:06 PM, Peter Krempa wrote:
On Mon, Jun 15, 2020 at 13:32:34 +0200, Michal Privoznik wrote:
This is a demo of the problem. Set up two NATed networks with dnsmasq and start a domain with two interfaces, one from each network. Only one network will report DHCP lease in 'virsh net-dhcp-leases'.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
I suggest you make use of the actual useful uses of a sign-off and that is to omit it for patches which are not meant to be pushed upstream. The pre-push hook will reject accidentally pushing it.
Ah, sure; It's just that I have this alias 'cs' which does commit + sign off and I am so used to commit using that.
BTW: did we migrate these pre-commit hooks to gitlab too?
Yes & no. You can't install arbitrary hooks server side. Instead we have a regex filter that checks for the word "Signed-off-by" in the commit message which applies when pushing directly to git. The CI job checks this for code that will go in via merge requests. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|