On 01/07/2014 06:09 AM, John Ferlan wrote:
On 01/06/2014 05:27 PM, Eric Blake wrote:
Ever since their introduction (commit 1509b80 in v0.5.0 for virConnectDomainEventRegister, commit 4445723 in v0.8.0 for virConnectDomainEventDeregisterAny), the event deregistration functions have been documented as returning 0 on success; likewise for older registration (only the newer RegisterAny must return a non-zero callbackID). And now that we are adding virConnectNetworkEventDeregisterAny for v1.2.1, it should have the same semantics.
Since they're a match set... I'll ACK 1 & 2 together.
Thanks; pushed.
I was going to comment about vbox_tmpl.c, but some things are just better left alone :-)
If more people were trying to backport vbox bug fixes to stable versions, then splitting the patch to fix the vbox bug in its own patch may have made more sense - but I don't get the sense that anyone will be bothered by me pushing this as one patch :) -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org