[PULL 03/25] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit"

From: Hyman Huang(黄勇) <yong.huang(a)smartx.com&gt; dirty_rate paraemter of hmp command "set_vcpu_dirty_limit" is invalid if less than 0, so add parameter check for it. Note that this patch also delete the unsolicited help message and clean up the code. Signed-off-by: Hyman Huang(黄勇) <yong.huang(a)smartx.com&gt; Reviewed-by: Markus Armbruster <armbru(a)redhat.com&gt; Reviewed-by: Peter Xu <peterx(a)redhat.com&gt; Reviewed-by: Juan Quintela <quintela(a)redhat.com&gt; Message-Id: <168618975839.6361.17407633874747688653-1(a)git.sr.ht&gt; Signed-off-by: Juan Quintela <quintela(a)redhat.com&gt; --- softmmu/dirtylimit.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/softmmu/dirtylimit.c b/softmmu/dirtylimit.c index 015a9038d1..e80201097a 100644 --- a/softmmu/dirtylimit.c +++ b/softmmu/dirtylimit.c @@ -515,14 +515,15 @@ void hmp_set_vcpu_dirty_limit(Monitor *mon, const QDict *qdict) int64_t cpu_index = qdict_get_try_int(qdict, "cpu_index", -1); Error *err = NULL; + if (dirty_rate < 0) { + error_setg(&err, "invalid dirty page limit %" PRId64, dirty_rate); + goto out; + } + qmp_set_vcpu_dirty_limit(!!(cpu_index != -1), cpu_index, dirty_rate, &err); - if (err) { - hmp_handle_error(mon, err); - return; - } - monitor_printf(mon, "[Please use 'info vcpu_dirty_limit' to query " - "dirty limit for virtual CPU]\n"); +out: + hmp_handle_error(mon, err); } static struct DirtyLimitInfo *dirtylimit_query_vcpu(int cpu_index) -- 2.40.1