Re: [libvirt] [PATCH] xen: Replace statsErrorFunc with a macro

On 04/16/2011 03:31 AM, Matthias Bolte wrote: > Also mark error messages in block_stats.c for translation, add the > new macro to the msg_gen functions in cfg.mk and add block_stats.c > to po/POTFILES.in > --- >  cfg.mk                |    1 + >  po/POTFILES.in        |    1 + >  src/xen/block_stats.c |   79 ++++++++++++++++++------------------------------ >  3 files changed, 32 insertions(+), 49 deletions(-) > > diff --git a/cfg.mk b/cfg.mk > index 94db937..e54d170 100644 > --- a/cfg.mk > +++ b/cfg.mk > @@ -420,6 +420,7 @@ msg_gen_function += xenUnifiedError >  msg_gen_function += xenXMError >  msg_gen_function += VIR_ERROR >  msg_gen_function += VIR_ERROR0 > +msg_gen_function += statsError Nit - is it worth sorting these lines by function name?

ACK.