On 03/03/2014 08:57 PM, Eric Blake wrote:
On 03/03/2014 08:47 AM, Ján Tomko wrote:
If systemd is installed, but not the init system,
Took me a couple reads to understand this. It would be easier with s/not/is not/
systemd-machined fails with an unhelpful error message: Launch helper exited with unknown return code 1
Currently we only check if the "machine1" service is available (in ListActivatableNames). Also check if "systemd1" service is registered with DBus (ListNames).
This fixes https://bugs.gentoo.org/show_bug.cgi?id=493246#c22 ---
ACK.
+{ + int ret = virDBusIsServiceInList("ListNames", name); + + VIR_DEBUG("Service %s is %sregistered", name, ret ? "not " : "");
Translation nightmare. But this string isn't marked for translation, so it's okay to hard-code English grammar into the ?:.
I've changed it to: VIR_DEBUG("Service %s is %s", name, ret ? "not registered" : "registered"); to make it easier to read and pushed it with the amended commit message. Jan