
25 Sep
2013
25 Sep
'13
4:47 p.m.
On 09/25/2013 08:51 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
For inexplicable reasons, the nwfilter XML parser is intentionally ignoring errors that arise during parsing. As well as meaning that users don't get any feedback on their XML mistakes, this will lead it to silently drop data in OOM conditions.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/conf/nwfilter_conf.c | 16 ++++++++-------- tests/nwfilterxml2xmltest.c | 14 ++++++-------- 2 files changed, 14 insertions(+), 16 deletions(-)
ACK 12-15. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org