On 09/09/2015 02:56 PM, Daniel P. Berrange wrote:
On Tue, Sep 08, 2015 at 09:27:23AM +0100, Joao Martins wrote:
Hey Jim,
This series bring support for various statistics about domains regarding CPU, Memory, Network Interfaces and BlockStats. Not all of the statistics are implemented: qdisk support is missing in this series and some of the memory statistics aren't available.
With this series we further implement 7 more functions of libvirt APIs. It is organized as follows:
* Patch 1, 2: implements cpu/memory statistics. * Patch 3, 4: implements (netback) network statistics and VBD block statistics. QDisk will follow up in a separate series regarding QEMU monitor integration. * Patch 5: implement fetching all domain statistics * Patch 6, 7: implements Job information.
Overall it looks big but 70% of the patch is due to #4 and #5 but doesn't add necessarily more complexity to the driver I believe. Patch #6 and #7 are of special importance because GetJobInfo and GetJobStats are now used in Openstack Kilo to monitor live-migration progress. This two patches together with an earlier series [0] I sent before let us sucessfully live-migrate with Openstack Kilo. Further with this series we get to support nova diagnostics.
Tested this series on 4.4.3 and 4.5 setups plus Openstack Kilo.
Any comments or suggestions are welcome,
I've not done a detailed review of all the patches, but overall it all looks conceptually sensible and likely mergable without much more work.
Thanks for the time reviewing it! Regards, Joao
Regards, Daniel