Re: [libvirt] [PATCH v2 0/2] {lxc, util}: Fix issues with NULL argument 'type' for mount().
Hi Michael,
Actually, "none" is not used. It is not the proper type there, but since it
is not used, we can go ahead. If we check the documentation, we can see
the text "The filesystemtype and data arguments are ignored." in options
BIND, MOVE and REMOUNT. So, no matter which option we put, the syscall
will ignore.
--
Julio Cesar Faracco
Em qui, 28 de jun de 2018 às 05:02, Michal Prívozník
<mprivozn(a)redhat.com> escreveu:
On 06/27/2018 05:06 PM, Julio Faracco wrote:
> This serie fixes the argument 'type' of syscall mount(). Valgrind is
> throwing an issue when that parameter 'type' of the syscall is NULL.
> The best option to fix this issue is replace NULL to "none"
> filesystem. For more details about the Valgrind bug, see the commit
> message at 794b576c.
>
> Julio Faracco (2):
> lxc: moving 'type' argument to avoid issues with mount() syscall.
> util: moving 'type' argument to avoid issues with mount() syscall.
>
> src/lxc/lxc_container.c | 26 +++++++++++++-------------
> src/util/vircgroup.c | 2 +-
> 2 files changed, 14 insertions(+), 14 deletions(-)
>
ACK to the patches. However, I'm not quite sure about safe-for-freeze. I
mean, patches will not break anything, but at the same time, it's not
that important bug they are fixing, or? What is your opinion in this? Is
is okay if I push them after the release?
Michal