1 Nov
2012
1 Nov
'12
11:39 a.m.
On Thu, Nov 01, 2012 at 07:38:16AM -0400, Alexander Larsson wrote:
+ /* Then we save the VMs to disk */ + for (i = 0 ; i < numDomains ; i++) + if (virDomainManagedSave(domains[i], flags[i]) < 0) + ret = -1;
Ok, so if any save fails we will report an error.
+ VIR_FREE(domains); + VIR_FREE(flags); + + ret = 0;
Eh, I guess not? I think we should though.
Opps, that's a bit of mixed up logic there. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|