On 2018年11月05日 23:02, John Ferlan wrote:
The code for determining resctrl allocation path could be reused for monitor. Refactor it for reuse.
Signed-off-by: Wang Huaqiang <huaqiang.wang@intel.com> --- src/util/virresctrl.c | 38 ++++++++++++++++++++++++++++++-------- 1 file changed, 30 insertions(+), 8 deletions(-)
diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index 6530801..956aca8 100644 --- a/src/util/virresctrl.c +++ b/src/util/virresctrl.c @@ -2265,28 +2265,50 @@ virResctrlAllocAssign(virResctrlInfoPtr resctrl, }
+static char * +virResctrlDeterminePath(const char *parentpath, + const char *prefix, + const char *id) +{ + char *path = NULL; + + if (!id) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Resctrl ID must be set before determining resctrl " + "parentpath='%s'"), parentpath); Add "for prefix='%s'" w/ prefix as argument especially since for Alloc's
On 10/22/18 4:01 AM, Wang Huaqiang wrote: the parent path is SYSFS_RESCTRL_PATH so it's perhaps not specific enough.
With this change that I can make for you,
Your change made the message be more clear. Agree with your change.
Reviewed-by: John Ferlan <jferlan@redhat.com>
John
Thanks for your review. Huaqiang
[...]