Re: [libvirt] [PATCHv2 07/10] openvz: Use strtok_r instead of sscanf for VPS UUID parsing

1 Apr 2010


      On 03/31/2010 03:42 PM, Matthias Bolte wrote:
...
Also free 2k stack space.
-        sscanf(line, "%s %s\n", iden, uuidbuf);
-        if(STREQ(iden, "#UUID:")) {
+        iden = strtok_r(line, " ", &saveptr);
+        uuidbuf = strtok_r(NULL, "\n", &saveptr);
+
+        if (iden != NULL && uuidbuf != NULL && STREQ(iden, "#UUID:")) {
ACK, and you did fix the bug from v1 that I had missed, by looking for
\n instead of \0.

-- 
Eric Blake   eblake@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org