Re: [libvirt] PATCH: Fix mingw32 build
On Fri, May 29, 2009 at 12:04:11PM -0400, Laine Stump wrote:
On 05/28/2009 12:37 PM, Daniel P. Berrange wrote:
>On Win32/mingw32 the name 'interface' is #defined to the COM_interface
>struct. Needless to say, libvirt thus fails to build in spectacular ways.
>
ACK!!! (That's the Bill the Cat "Yuck!" kind, not the open source
"Looks
good, okay." kind ;-)
What should I be doing to avoid putting you to this trouble again in the
future? Can I do a cross build of the mingw target on Fedora, or do I
need to dust off my Windows street cred and setup a Windows VM?
If you want to test Win32 builds (its not compulsory for patch submitters)
then Fedora includes a big set of mingw32 packages you can use. See the
mingw-libvirt.spec file in the source dir for pre-requisites, and
example configure args you can use on mingw32
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|