Re: [PATCH v2 0/9] docs: Fix migration.html generation and report such errors next time
On Tue, Oct 13, 2020 at 06:30:32PM +0200, Peter Krempa wrote:
On Tue, Oct 13, 2020 at 18:18:04 +0200, Peter Krempa wrote:
> This version refactors the XSLT transformation command a bit more
> carefully and thoroughly. A semantic difference in v2 is that the output
> HTMLs are no longer reformatted.
The output can be verified here:
https://gitlab.com/pipo.sk/libvirt/-/jobs/788658848/artifacts/browse/webs...
Yeah, that shows me I need to do one other fix for the migration.html (see last
code block) or our stylesheet (probably the former, though).
Anyway this looks good except one tiny little thing (or three), so
Reviewed-by: Martin Kletzander <mkletzan(a)redhat.com>
if you fix s/an comment/a comment/ in commit messages for patches 6, 7 and 8 ;-)
Thanks for fixing my error and making the build even better.
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)