"Daniel P. Berrange" <berrange@redhat.com> wrote on 03/18/2010 12:51:55 PM:


>
> Please respond to "Daniel P. Berrange"
>
> On Thu, Mar 18, 2010 at 10:41:58AM -0600, Eric Blake wrote:
> > On 03/18/2010 09:15 AM, Stefan Berger wrote:
> > > This patch adds recursive locks necessary due to the processing of
> > > network filter XML that can reference other network filters, including
> > > references that cause looks. Loops in the XML are prevented but their
> > > detection requires recursive locks.
> >
> > ACK.  I had to double-check MSDN to make sure that threads-win32 already
> > creates recursive mutex by default.
>
> I don't supposed you read if its possible to make it non-recursive, since
> the orginal impl is supposed to be non-recursive !
>

From what I remember from some msdn page is that the win32 mutexes are all recursive. So, the call that I made for creating a recursive mutex by calling the virMutexInit() function is not correct -- it should be the other way around...  Something to fix some other day ?

  Stefan


> Daniel
> --
> |: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/:|
> |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org:|
> |: http://autobuild.org        -o-         http://search.cpan.org/~danberr/:|
> |: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|