On Thu, 2019-04-18 at 16:54 +0200, Michal Privoznik wrote: [...]
# Location of master nvram file # +# This configuration option is obsolete. Libvirt will follow the +# QEMU firmware metadata specification to automatically locate +# firmware images: +# +# https://git.qemu.org/gitweb.cgi?p=qemu.git;a=blob_plain;f=docs/interop/firmw...
Using 'a=blob_plain' results in my browser (Firefox) trying to parse the file and complaining loudly: SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data Changing it to 'a=blob' gives me a nice page which, among other things, also contains a link to the raw version, so I would go with that one instead. Alternatively, you could just say See docs/interop/firmware.json in the QEMU source tree. and leave the URL out entirely: it's not like users, who are the target of the comment, will actually want to read the spec :)
+# +# These metadata files are distributed alongside any firmware +# images intended for use with QEMU.
Leave an empty line here. You could even do something like # images intended for use with QEMU. # # ------------------------------------------ # # When a domain is configured to use UEFI instead of standard to make it extremely obvious the part after the cut is documentation for the now obsolete configuration option. -- Andrea Bolognani / Red Hat / Virtualization