Re: [libvirt] [PATCH 2/5] xen: Remove extraneous checks in xenStoreGetDomainInfo()

The VIR_IS_CONNECTED_DOMAIN() will already check/return -1 if domain or domain->conn are NULL. --- src/xen/xs_internal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xen/xs_internal.c b/src/xen/xs_internal.c index 9308522..4ccab20 100644 --- a/src/xen/xs_internal.c +++ b/src/xen/xs_internal.c @@ -382,7 +382,7 @@ xenStoreGetDomainInfo(virDomainPtr domain, virDomainInfoPtr info) if (!VIR_IS_CONNECTED_DOMAIN(domain)) return -1; - if ((domain == NULL) || (domain->conn == NULL) || (info == NULL)) { + if (info == NULL) { virReportError(VIR_ERR_INVALID_ARG, __FUNCTION__); return -1; }