Re: [libvirt] [jenkins-ci PATCH] lcitool: Explain our use of the 'ks' kernel parameter
On Tue, 2019-12-03 at 12:30 +0100, Erik Skultety wrote:
On Tue, Dec 03, 2019 at 12:19:55PM +0100, Andrea Bolognani wrote:
> extra_arg = "console=ttyS0
ks=file:/{}".format(install_config)
On a side note - I'm pretty sure I've already mentioned it in the past, but we
should convert to the 'inst.ks' syntax instead of plain 'ks', anaconda
currently accepts both [1], but it documents that *all* installer options are
prefixed with 'inst.' and in future releases it may stop accepting the older
syntax.
Is the new syntax supported by RHEL/CentOS 7? That would be the only
obstacle to its adoption. If you have time to cook a patch and verify
it doesn't cause regressions, I'll gladly take it :)
To the patch itself:
Reviewed-by: Erik Skultety <eskultet(a)redhat.com>
Thanks! Pushed now.
--
Andrea Bolognani / Red Hat / Virtualization