Re: [libvirt] [PATCH 1/2] perf: Compute cache_l1d config value correctly

This patch computes the .attrConfig value for cache_l1d correctly and updates the documentation. The cache_l1d perf event now is renamed as cache_l1dra perf event for measuring read accesses for level 1 data cache Signed-off-by: Nitesh Konkar <nitkon12(a)linux.vnet.ibm.com&gt; --- docs/formatdomain.html.in | 12 ++++++------ docs/news.xml | 5 +++-- docs/schemas/domaincommon.rng | 2 +- include/libvirt/libvirt-domain.h | 12 ++++++------ src/libvirt-domain.c | 5 +++-- src/qemu/qemu_driver.c | 2 +- src/util/virperf.c | 8 +++++--- src/util/virperf.h | 2 +- tests/genericxml2xmlindata/generic-perf.xml | 2 +- tools/virsh.pod | 6 +++--- 10 files changed, 30 insertions(+), 26 deletions(-)

diff --git a/src/util/virperf.c b/src/util/virperf.c index 8554723..11e64df 100644 --- a/src/util/virperf.c +++ b/src/util/virperf.c @@ -113,9 +113,11 @@ static struct virPerfEventAttr attrs[] = { .attrConfig = 0, # endif }, .attrType = PERF_TYPE_HW_CACHE, - .attrConfig = PERF_COUNT_HW_CACHE_L1D}, + .attrConfig = (PERF_COUNT_HW_CACHE_L1D) | + (PERF_COUNT_HW_CACHE_OP_READ << 8) | + (PERF_COUNT_HW_CACHE_RESULT_ACCESS << 16)}, };