Re: [libvirt] [PATCH v4 0/8]: Add arbitrary qemu command-line and monitor commands

On Wed, Jul 07, 2010 at 05:33:25PM -0400, Chris Lalancette wrote: > As we discussed previously, here is the patch series to add the ability > to specify arbitrary qemu command-line parameters and environment variables, > and also give arbitrary monitor commands to a guest. Because these > extra arguments have a good shot at confusing libvirt, the use of them > is not supported, but left available for advanced users and developers. > They are also in a separate library and have a separate on-the-wire > protocol. > > There is one bug left that I have not yet been able to fix. Because of the > complicated way that virsh parses command-line arguments, it is not possible > to pass through spaces and quotes when using the qemu-monitor-command. > Unfortunately, the qemu monitor commands (and in particular when using QMP) > depend heavily on quoting and spacing, so using virsh to send through > command-lines is difficult. I'll have to think about how to better resolve > this issue, but it should not hold up the rest of the series. Aside from the bug about the libvirt_public.sym file I think this series is ok to commit. Given that we don't have a solution for this virsh quoting problem though, we should leave out the virsh patch. We don't want to lock ourselves into current syntax of 'qemu-monitor-command' in case the solution to quoting problem requires changes.