Re: [PATCH 6/9] Revert "qemu_conf: Track embed root dir"
On Wed, 2020-03-25 at 11:18 +0100, Michal Privoznik wrote:
This reverts commit 06a19921b6a522cd7b4d352c9320909752947de3.
What I haven't realized when writing this ^^ commit is that the
virQEMUDriver structure already stores the root directory path.
And since the pointer is immutable it can be accessed right from
the structure and thus there is no need to duplicate it in the
driver config.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/qemu/qemu_conf.c | 2 --
src/qemu/qemu_conf.h | 2 --
2 files changed, 4 deletions(-)
Funnily enough, when reviewing the original patch I wanted to point
out that something like "embedRoot" would have been a better name for
the member, but then opted to leave out the bikeshedding... I wonder
if we would have realized earlier about this if I hadn't :)
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization