On 01/10/2012 03:50 AM, Daniel P. Berrange wrote:
On Wed, Dec 14, 2011 at 10:50:01AM +0000, Shradha Shah wrote:
--- src/util/pci.c | 16 ++++++++++++++++ src/util/pci.h | 2 ++ 2 files changed, 18 insertions(+), 0 deletions(-)
In addition to Daniel's comments,
+int +pciSysfsFile(char *pciDeviceName, char **pci_sysfs_device_link) +{ + if (virAsprintf(pci_sysfs_device_link, PCI_SYSFS "devices/%s", + pciDeviceName) < 0) { + virReportOOMError(); + return -1; + } +
Trailing whitespace. 'make syntax-check' caught this.
+int pciSysfsFile(char *pciDeviceName, char **pci_sysfs_device_link); We could add the 'ATTRIBUTE_RETURN_CHECK' annotation to this method
#endif /* __VIR_PCI_H__ */
ACK
I've got some time to apply the necessary minor fixes, so I'll push the corrected series in the next hour or so. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org