Re: [libvirt] [PATCH] cygwin: Check explicitly for getmntent_r
2010/4/23 Eric Blake <eblake(a)redhat.com>:
On 04/23/2010 10:57 AM, Matthias Bolte wrote:
> Cygwin has mntent.h but lacks getmntent_r. Update preprocessor
> checks to catch this combination.
Ultimately, cygwin might be taught to implement getmntent_r, so this may
have to be revisited in the future. But that said,
This sentence seems incomplete.
> +++ b/src/qemu/qemu_conf.c
> @@ -114,7 +114,7 @@ int qemudLoadDriverConfig(struct qemud_driver *driver,
> return -1;
> }
>
> -#ifdef HAVE_MNTENT_H
> +#if defined HAVE_MNTENT_H && defined HAVE_GETMNTENT_R
This looks like a reasonable solution to allow compilation on cygwin;
and we can deal with any fallout in later patches.
ACK.
Thanks, pushed.
Matthias