On 07/10/2014 07:42 AM, David Kiarie wrote:
From: Kiarie Kahurani <davidkiarie4(a)gmail.com>
Introduce function xenParseXMGeneral(virConfPtr conf, ...);
This function parses the xm general options such as uuid and name
[meta-comment]:
When posting a series, it's useful to post a cover letter (0/17) to
which all patches reply to, rather than having 2-17 reply to 1/17 with
no lead-in on the series as a whole.
signed-off-by: David Kiarie <davidkiarie4(a)gmail.com>
---
src/xenxs/xen_xm.c | 65 +++++++++++++++++++++++++++++++-----------------------
1 file changed, 37 insertions(+), 28 deletions(-)
diff --git a/src/xenxs/xen_xm.c b/src/xenxs/xen_xm.c
index 25a042d..1953a85 100644
--- a/src/xenxs/xen_xm.c
+++ b/src/xenxs/xen_xm.c
@@ -253,44 +253,25 @@ xenXMConfigGetUUID(virConfPtr conf, const char *name, unsigned char
*uuid)
* Turn a config record into a lump of XML describing the
* domain, suitable for later feeding for virDomainCreateXML
*/
-virDomainDefPtr
-xenParseXM(virConfPtr conf, int xendConfigVersion,
- virCapsPtr caps)
+static int xenParseXMGeneral(virConfPtr conf, virDomainDefPtr def,
+ virCapsPtr caps)
Indentation is off; per our style, this should be:
static int
xenParseXMGeneral(virConfPtr conf, virDomainDefPtr def,
virCapsPtr caps)
+}
+virDomainDefPtr
2 blank lines between functions.
+xenParseXM(virConfPtr conf, int xendConfigVersion,
+ virCapsPtr caps)
Indentation is off; the second line should line up to the character
after the ( of the first line.
Otherwise, this looks like it is just a refactoring of splitting out a
helper function for later reuse.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org