On Thu, Feb 22, 2018 at 08:15:26AM +0100, Michal Privoznik wrote:
On 02/21/2018 04:22 PM, Daniel P. Berrangé wrote:
Currently building --without-libvirtd causes a failure to link the node device driver:
node_device/.libs/libvirt_driver_nodedev_la-node_device_driver.o: In function `nodedevRegister': /home/berrange/src/virt/libvirt/src/node_device/node_device_driver.c:649: undefined reference to `udevNodeRegister' collect2: error: ld returned 1 exit status
because it causes us to build the core nodedev driver, but then skip the implementations, despite udev being available.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- src/Makefile.am | 2 -- 1 file changed, 2 deletions(-)
ACK, although you already pushed this. You could use both rules for pushing patches without review - this patch fixes broken build and is trivial. Speaking of which, do we document the rules somewhere? I don't think we do.
Opps, yes, I actually pushed this without realizing I had left it in master ! I don't think we have ever documented the trivial/build breaker fix guidelines explicitly. I just tend to explain them to people when I granted them commit access. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|