Re: [libvirt] [PATCH 2/6] qemu: virsh wrapper for qemu events

On Fri, Jan 31, 2014 at 07:12:07PM -0700, Eric Blake wrote: > Any new API deserves a good virsh wrapper :) > > qemu-monitor-event [<domain>] [<event>] [--pretty] [--loop] [--timeout <number>] >

> > * tools/virsh-domain.c (cmdQemuMonitorEvent): New command. > * tools/virsh.pod (qemu-monitor-event): Document it. I can't help thinking that we should have a general 'virsh domain-event' command before we go adding a qemu specific one here. Without a generic command we'd be forcing people to use the QEMU specific command even for events where we have general support like your shutdown example.