On Thu, Feb 20, 2025 at 05:11:36PM -0700, Jim Fehlig via Devel wrote:
Long ago, without justification, commit 48cb9f0542 changed qemuGetCompressionProgram (since renamed to qemuSaveImageGetCompressionProgram) to ignore configuration errors for dump operations. Like the other save-related operations, user provided configuration should be verified and an error reported if it cannot be honored.
Remove the special handling of configuration errors in qemuSaveImageGetCompressionProgram and change the dump logic to fail when dump image format cannot be supported.
Signed-off-by: Jim Fehlig <jfehlig@suse.com> --- src/qemu/qemu_driver.c | 19 ++++-------- src/qemu/qemu_saveimage.c | 61 ++++++++++----------------------------- src/qemu/qemu_saveimage.h | 3 +- src/qemu/qemu_snapshot.c | 2 +- 4 files changed, 24 insertions(+), 61 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|