Re: [libvirt] [PATCH 2/2] conf: do not steal pointers from the pool source

On Tue, Mar 28, 2017 at 03:22:08PM +0200, Ján Tomko wrote:

Since commit fcbbb28 we steal the pointer to the storage pool source name if there was no pool name specified.

Properly duplicate the string to avoid freeing it twice.

https://bugzilla.redhat.com/show_bug.cgi?id=1436400 --- src/conf/storage_conf.c | 5 +++-- tests/storagepoolxml2xmlout/pool-logical-noname.xml | 19 +++++++++++++++++++ tests/storagepoolxml2xmltest.c | 1 + 3 files changed, 23 insertions(+), 2 deletions(-) create mode 100644 tests/storagepoolxml2xmlout/pool-logical-noname.xml

The ACK from the previous one was meant for both patches, but I didn't mention it for some reason. So ACK to this one as well.