Re: [PATCH libvirt v1 5/6] tests: qemu: add more tests for ZPCI on S390

8 Jun 2020


      Hi Andrea,

Thank you for the review.

On 6/3/20 2:45 PM, Andrea Bolognani wrote:
...
On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote:
...
+++ b/tests/qemuxml2argvtest.c
@@ -1650,6 +1655,12 @@ mymain(void)
      DO_TEST("hostdev-vfio-zpci-autogenerate",
              QEMU_CAPS_DEVICE_VFIO_PCI,
              QEMU_CAPS_DEVICE_ZPCI);
+    DO_TEST("hostdev-vfio-zpci-autogenerate-uids",
+            QEMU_CAPS_DEVICE_VFIO_PCI,
+            QEMU_CAPS_DEVICE_ZPCI);
+    DO_TEST("hostdev-vfio-zpci-autogenerate-fids",
+            QEMU_CAPS_DEVICE_VFIO_PCI,
+            QEMU_CAPS_DEVICE_ZPCI);
You want to add the successfult tests to qemuxml2xmltest.c as well.
Everything else looks good.
Thank you, ok I will add them.


    