Re: [PATCH 6/6] docs: document panic device 'pvpanic-pci'
On Thu, Feb 09, 2023 at 08:41:01 -0800, Andrea Bolognani wrote:
On Wed, Feb 08, 2023 at 01:09:05PM +0100, Peter Krempa wrote:
> On Wed, Feb 08, 2023 at 12:49:05 +0100, Kristina Hanicova wrote:
> > +++ b/docs/formatdomain.rst
> > @@ -7940,6 +7940,7 @@ Example: usage of panic configuration
> > - 'hyperv' - for Hyper-V crash CPU feature. :since:`Since 1.3.0,
QEMU and
> > KVM only`
> > - 's390' - default for S390 guests. :since:`Since 1.3.5`
> > + - 'pvpanic' - for PCI pvpanic devicen :since:`Since 9.1.0, QEMU
and KVM only`
>
> s/devicen/device/
>
> Also is KVM really required? I'd expect that it will also work with TCG
> VMs.
I think so as well. But to be honest I'm unclear on what "QEMU and
KVM only", as used extensively throughout the document, is intended
to mean. Does it mean "only when using the QEMU driver and its KVM
domain type", or rather "only when using the QEMU or KVM domain
type"? The latter sounds more likely to me, and it would be accurate
for the pvpanic-pci device.
Generaly in our docs "QEMU only" means that it works only with the qemu
driver/hypervisor, thus I don't think the interpretation that <domain
type='qemu'> or kvm will work here.