On Wed, Dec 16, 2009 at 12:04:00AM +0100, Jiri Denemark wrote:
Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- include/libvirt/libvirt.h.in | 13 +++++++++++++ src/libvirt_public.syms | 5 +++++ 2 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index 6c3aded..473d2a2 100644 --- a/include/libvirt/libvirt.h.in +++ b/include/libvirt/libvirt.h.in @@ -1676,6 +1676,19 @@ int virInterfaceIsActive(virInterfacePtr iface); int virConnectIsEncrypted(virConnectPtr conn); int virConnectIsSecure(virConnectPtr conn);
+/* + * CPU specification API + */ + +typedef enum { + VIR_CPU_COMPARE_ERROR = -1, + VIR_CPU_COMPARE_INCOMPATIBLE = 0, + VIR_CPU_COMPARE_IDENTICAL = 1, + VIR_CPU_COMPARE_SUPERSET = 2 +} virCPUCompareResult; + +int virConnectCompareCPU(virConnectPtr conn, + const char *xmlDesc);
Hum, I would add an unsigned int flags there for potential evolution of the semantic. It can be maked as unused in the libvirt.c front-end if you don't want to pass it down to drivers yet minimizing the changes.
#ifdef __cplusplus diff --git a/src/libvirt_public.syms b/src/libvirt_public.syms index b4f57e7..538b4d4 100644 --- a/src/libvirt_public.syms +++ b/src/libvirt_public.syms @@ -343,4 +343,9 @@ LIBVIRT_0.7.3 { virInterfaceIsActive; } LIBVIRT_0.7.2;
+LIBVIRT_0.7.5 { + global: + virConnectCompareCPU; +} LIBVIRT_0.7.3; + # .... define new API here using predicted next version number ....
ACK with the flags or with a good justification against. -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/