On Thu, Dec 29, 2011 at 09:56:02PM +0800, Daniel Veillard wrote:
On Thu, Dec 29, 2011 at 09:37:42PM +0800, Osier Yang wrote:
On 2011年12月29日 21:19, Daniel Veillard wrote:
As seen in https://bugzilla.redhat.com/show_bug.cgi?id=746111
If compiled with the daemon and avahi support, then it's better to require avahi at the rpm level to avoid daemon startup errors.
diff --git a/libvirt.spec.in b/libvirt.spec.in index 5537c51..dd5e32f 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -272,6 +272,9 @@ Requires: %{name}-client = %{version}-%{release} Requires: module-init-tools # for /sbin/ip& /sbin/tc Requires: iproute +%if ! %{with_avahi}
This should be below instead?
if %{with_avahi}
Urgh, definitely !
+Requires: avahi +%endif %endif %if %{with_network} Requires: dnsmasq>= 2.41
Assuming I didn't maanage to make 2 mistakes in 3 trivial lines like this I pushed the following :-) As seen in https://bugzilla.redhat.com/show_bug.cgi?id=746111 If compiled with the daemon and avahi support, then it's better to require avahi at the rpm level to avoid daemon startup errors. diff --git a/libvirt.spec.in b/libvirt.spec.in index 5537c51..4b98e4a 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -272,6 +272,9 @@ Requires: %{name}-client = %{version}-%{release} Requires: module-init-tools # for /sbin/ip & /sbin/tc Requires: iproute +%if %{with_avahi} +Requires: avahi +%endif %endif %if %{with_network} Requires: dnsmasq >= 2.41 -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/