Re: [libvirt] [PATCH] Allow building lxc without virt-login-shell

On Fri, Nov 20, 2015 at 04:42:56PM +0100, Cedric Bosdonnat wrote: > On Fri, 2015-11-20 at 16:29 +0100, Michal Privoznik wrote: >> On 10.11.2015 00:28, Cédric Bosdonnat wrote: >>> Add a configure option to disable virt-login-shell build even if lxc is >>> enabled. >>> --- >>> configure.ac | 14 ++++++++++++++ >>> tools/Makefile.am | 12 ++++++------ >>> 2 files changed, 20 insertions(+), 6 deletions(-) >>> >>> diff --git a/configure.ac b/configure.ac >>> index f481c50..c766351 100644 >>> --- a/configure.ac >>> +++ b/configure.ac >>> @@ -1074,6 +1074,19 @@ if test "$with_lxc" = "yes" ; then >>> fi >>> AM_CONDITIONAL([WITH_LXC], [test "$with_lxc" = "yes"]) >>> >>> +AC_ARG_WITH([login_shell], >>> + [AS_HELP_STRING([--with-login-shell], >>> + [build virt-login-shell @<:@default=yes@:>@])]) >>> +m4_divert_text([DEFAULTS], [with_login_shell=yes]) >>> + >>> +if test "$with_lxc" != "yes" ; then >>> + with_login_shell="no" >> >> what if somebody calls ./configure --without-lxc --with-login-shell? >> Should we fail explicitly instead of silently disabling login shell? > > No idea what is the best thing to do... but surely an error would be > more explicit indeed. That is still a valid configuration, because virt-login-shell doesn't hve a build-time dependancy on the LXC driver - only the libvirt-lxc.so client library which is built unconditionally.