Re: [libvirt] [PATCH 5/5] snapshot: implement getparent in qemu
On 09/28/2011 07:22 AM, Daniel Veillard wrote:
> @@ -10432,6 +10477,7 @@ static virDriver qemuDriver = {
> .domainSnapshotListNames = qemuDomainSnapshotListNames, /* 0.8.0 */
> .domainSnapshotLookupByName = qemuDomainSnapshotLookupByName, /* 0.8.0 */
> .domainHasCurrentSnapshot = qemuDomainHasCurrentSnapshot, /* 0.8.0 */
> + .domainSnapshotGetParent = qemuDomainSnapshotGetParent, /* 0.9.7 */
> .domainSnapshotCurrent = qemuDomainSnapshotCurrent, /* 0.8.0 */
> .domainRevertToSnapshot = qemuDomainRevertToSnapshot, /* 0.8.0 */
> .domainSnapshotDelete = qemuDomainSnapshotDelete, /* 0.8.0 */
ACK, any change to get this implemented for other drivers ?
I don't have ESX or VBox set up to test things, but I'll give the code a
shot if someone else can review the actual implementation. Those are
the only two other hypervisors with snapshots at the moment, and since
they already have the ability to report parent information into the
generated xml, I believe it should be doable to implement this new function.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org