
10 Dec
2010
10 Dec
'10
5:33 p.m.
On 12/10/2010 10:26 AM, Matthias Bolte wrote:
2010/12/10 Eric Blake <eblake@redhat.com>:
* src/util/command.c (virCommandFree): Free data from virCommandSetInputBuffer.
At first I wanted to complain that virCommandSetInputBuffer isn't documented to take ownership of the inbuf, then I saw that it's strdup'ed :)
Yeah, virCommandSetInputBuffer takes char*, virCommandSetOutputBuffer takes char**; leaving subtly different lifetimes for the resulting strings.
ACK.
Thanks; pushed. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org