On 08/15/12 15:33, Daniel P. Berrange wrote:
On Sat, Aug 11, 2012 at 11:20:58PM +0200, Peter Krempa wrote:
This is a second respin of the LibSSH2 transport patch series.
The most notable changes: ------------------------- - Rebased on top of current upstream (virObject, new error codes) - ported to use virObject stuff - re-named all functions and other literals to contain the "2" - implemented suggestions from Eric's review - added symbol file and various other cleanups
The easiest way to test the actual implementation is to apply the patchset and try connecting to a remote host using virsh and then trying some API's. The most complex part of the code are the various authentication options that can be selected in the connection URI.
I think this is good to get into 0.10.0 release, but can you send a further patch describing the URI options for docs/remote.html.in
Thanks for the review. I fixed all the places you suggested, renamed the functions and fixed a few bugs that I found while doing the last tests and pushed the series. I'll send an aditional patch describing the usage in docs, but I wanted to settle the user exposed parts at first. Peter
Daniel