Re: [libvirt] [libvirt-glib 1/4] config: Implement gvir_config_domain_graphics_spice_set_listen

On Tue, Sep 25, 2012 at 02:07:39PM +0200, Michal Privoznik wrote: Hey, As I understand it, to listen on an IP address or a network, you'd use a <listen> child node to the <graphics> node. This patch sets the 'listen' attribute on the <graphics> node, which is only about listening on an IP address if I didn't miss anything (?). <listen> nodes would be handled in a separate class, but there could indeed be an ambiguity between a setter for an object of this type, and this API. It seems it's not necessarily an IP address but this can be a hostname if the .rng is to be trusted. I had in the back of my mind the possibility of adding _set_listen_address which accepts a GInetAddress or something like that (just vague thoughts, I don't have a clear idea about that ;). So maybe _set_listen_str would work to avoid the ambiguity? Though as I write this mail, this looks weird too... Christophe