Re: [libvirt] [PATCH 3/7] vbox: avoid problematic uses of sprintf

> - /* Assuming can't have more then 9999 devices so > - * restricting to %04d > + /* Zero pad for nice alignment when fewer than 9999 > + * devices. > */ > - sprintf(filtername, "filter%04d", i); > - VBOX_UTF8_TO_UTF16(filtername,&filternameUtf16); > + if (virAsprintf(&filtername, "filter%04d", i)< 0) { > + virReportOOMError(); > + } else { > + VBOX_UTF8_TO_UTF16(filtername,&filternameUtf16); > + VIR_FREE(filtername); > + } > > USBController->vtbl->CreateDeviceFilter(USBController, > filternameUtf16, In case virAsprintf fails CreateDeviceFilter will be called with filternameUtf16 = NULL, that might trigger a segfault.