Re: [libvirt] [PATCH] qemu: Fix parsing of x86 CPU models
On Mon, Oct 08, 2012 at 05:08:00PM +0200, Jiri Denemark wrote:
On Mon, Oct 08, 2012 at 15:55:09 +0100, Daniel P. Berrange wrote:
> My feeling is that we came to agreement with the QEMU developers that we
> would exclusively useful QMP probing with any QEMU from 1.2.0 or later
> and would not try to follow changes they make to the non-QMP interfaces
> we previously relied on. So if there are any changes to -help, -cpu, -M
> or -device output from 1.2.0 onwards, we really should not try to follow
> them in libvirt master.
>
> I could see this patch being acceptable for our newest stable release
> stream branch though. Traditionally our requriement was that patches
> for stable should go in master first, but I think this scenario is an
> example where we should relax that rule and put the change in the stable
> branch only.
Although it will only help if someone updates QEMU while staying on a stable
libvirt branch. I'm not saying it's a bad idea, though :-) Can I take this as
an ACK for pushing into the stable branch?
Hmm, now that I've said this, I have a strong feeling that this is a lost
cause because other changes to QEMU master are going to break compatibility
with the libvirt stable branch soon enough (if not already).
Perhaps we should just update drvqemu.html to clearly indicate that if
you have QEMU >= 1.3.0 you need to have libvirt >= 1.0.0.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|