Re: [PUSHED PATCH] spec: Explicitly disable userfaultfd_sysctl for mingw
On a Wednesday in 2024, Pavel Hrdina wrote:
On Wed, Feb 14, 2024 at 01:31:29PM +0100, Peter Krempa wrote:
> On Tue, Feb 13, 2024 at 19:16:00 +0100, Jiri Denemark wrote:
> > The %meson* macros pass --auto-features=enabled to enable all "auto"
> > features, which means we have to explicitly disable them.
>
> This is not the first time we've hit this. I really think the only sane
> option for --auto-features= for distributions is to use 'disabled' and
> explicitly enable what they need.
This is our own fault as Jano already pointed out here [1] we have the
option '--auto-features=enabled' in our own spec file for mingw [2].
It is also set to enabled by the '%mingw' RPM macro on Fedora.
Personally, I think it's frendlier for maintainers to be bothered by these
"errors" rather than having the users miss new features.
Jano
Pavel
[1]
<https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/R...
[2]
<https://gitlab.com/libvirt/libvirt/-/blob/master/libvirt.spec.in?ref_type...
_______________________________________________
Devel mailing list -- devel(a)lists.libvirt.org
To unsubscribe send an email to devel-leave(a)lists.libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 228 bytes)