On Wed, Apr 30, 2008 at 07:24:42PM +0200, Jim Meyering wrote:
Unfortunately, the above no longer applies, due to upstream (gnulib) changes to deal with non-srcdir (aka VPATH) builds. I updated libvirt from gnulib just yesterday, and will again, later today. Can you adapt your patch to make bzr work with the newer version? I'll do it when you're done updating gnulib. I'm done for now, and pulled the new version into libvirt.
Ok, I'll fix up the patch later tonight.
Well, if anyone insists on not changing something that only works with bash to something that works with any shell (${*:-*} vs. ${*-*}) , but also refuses to put /bin/bash explicitly as the interpreter is just being pointlessly difficult, IMO. Um... maybe you didn't notice that I removed the problematic syntax altogether?
Sure. I'm just pointing out that if *someone* were to insist that this is "an Ubuntu problem, because we don't use the same /bin/sh as most other distros", I'd be rather annoyed.
Here's the patch I've pushed to gnulib:
http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=173a9f0c48a16c3507...
That patch will make the cvs case fail, too. It will prepend a ./ to all path names which will screw with the comparison, AFAICS. It handled one case. The two subsequent patches addressed the others.
Oh, ok. Sorry. I thought they would adress different things. I can't see them in that git tree, I think? -- Soren Hansen | Virtualisation specialist | Ubuntu Server Team Canonical Ltd. | http://www.ubuntu.com/