Re: [libvirt] [PATCH v2 1/3] tests: qemuxml2argv: make CAPS_LATEST arch generic

On Tue, Jul 24, 2018 at 13:31:04 +0200, Boris Fiuczynski wrote: > From: Bjoern Walk <bwalk(a)linux.ibm.com&gt; > > Testing with the latest capabilities has been x86_64 centric. Let's > remove the hardcoded architecture and give the user the ability to > specify the desired architecture in the macro. > > Signed-off-by: Bjoern Walk <bwalk(a)linux.ibm.com&gt; > Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com&gt; > --- > tests/qemuxml2argvtest.c | 96 ++++++++++++++++++++++------------------ > 1 file changed, 54 insertions(+), 42 deletions(-) [...] > @@ -746,9 +758,9 @@ mymain(void) > # define DO_TEST_CAPS_VER(name, ver) \ > DO_TEST_CAPS_ARCH_VER(name, "x86_64", ver) > > -# define DO_TEST_CAPS_LATEST(name) \ > - DO_TEST_CAPS_INTERNAL(name, "x86_64-latest", NULL, 0, 0, "x86_64", \ > - capslatest_x86_64, true) > +# define DO_TEST_CAPS_LATEST(name, arch) \ > + DO_TEST_CAPS_INTERNAL(name, arch "-latest", NULL, 0, 0, arch, \ > + virHashLookup(capslatest, arch), true) Please add a DO_TEST_CAPS_LATEST_ARCH version rather than modifying all of the calls. We have a vast majority of x86_64 tests so we should not need to change them.

-- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list