Re: [libvirt] [PATCH 08/14] secret: Change variable names for list traversals
On 04/25/2017 04:47 AM, Pavel Hrdina wrote:
On Mon, Apr 24, 2017 at 02:00:17PM -0400, John Ferlan wrote:
> Rather than 'nuuids' it should be 'maxuuids' and rather than
'got'
> it should be 'nuuids'. Alter the logic of the list traversal to
> utilize those names.
>
> Also alter the cleanup in virSecretObjListGetUUIDs to return on success
> and handle failure with a -1 return instead of the if (ret < 0) logic.
Even this logic change is minimal it's better to have the rename changes
in a separate commit.
I can split them further before pushing
John
ACK anyway
Pavel