On Wed, Oct 07, 2009 at 03:36:18PM -0400, Amy Griffis wrote:
Daniel P. Berrange wrote: [Mon Oct 05 2009, 08:52:20AM EDT]
ACK, although it'd need a small change for my suggested API contract change in your previous patch in the series
Updated for API change...
Before launching the lxc controller, have the lxc driver query the log settings and setup envp[]. This provides the advantage of honoring the actual log configuration instead of only what had been set in the environment. The lxc controller now simply has to call virLogSetFromEnv(). ---
src/lxc/lxc_controller.c | 3 ++ src/lxc/lxc_driver.c | 77 ++++++++++++++++++++++++++++++++++++++++------ 2 files changed, 70 insertions(+), 10 deletions(-)
ACK Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|