Re: [libvirt] [jenkins-ci PATCH 2/2] jobs: Switch to github webhook instead of polling
On Thu, Jun 21, 2018 at 03:37:49PM +0200, Andrea Bolognani wrote:
On Thu, 2018-06-21 at 14:21 +0200, Pavel Hrdina wrote:
[...]
> @@ -31,8 +31,7 @@
> triggers:
> - reverse:
> jobs: '{obj:parent_jobs}'
> - - pollscm:
> - cron: "H/20 * * * *"
> + - github
As noted in the review for the previous patch
libosinfo: https://gitlab.com/libosinfo/libosinfo.git
osinfo-db-tools: https://gitlab.com/libosinfo/osinfo-db-tools.git
osinfo-db: https://gitlab.com/libosinfo/osinfo-db.git
virt-viewer: https://pagure.io/virt-viewer.git
are not hosted on GitHub, so the above won't work for them.
There's probably a way to make something like this work for GitLab
too, but I'm not very confident about Pagure.
Perhaps we can convince the projects listed above to set up
mirroring to GitHub...
I think its better if we just leave the jenkins config using pollscm
as it does today, but simply point it at an appropriate repo for
each project, instead of using github webhooks or the local cached
git.
This kind of need to mirror/move everything to github just to use
their unique features, is exactly the kind of embrace & extend that
makes github undesirable. Better to stick to core git functionality.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|