Re: [libvirt] [PATCH v1 31/37] Adapt to VIR_ALLOC and virAsprintf in src/vmx/*

On 07/04/13 14:06, Michal Privoznik wrote:

--- src/vmx/vmx.c | 92 +++++++++++++++-------------------------------------------- 1 file changed, 23 insertions(+), 69 deletions(-)

diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 5464d13..64bf4be 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c

...

@@ -3342,10 +3298,8 @@ virVMXFormatConfig(virVMXContext *ctx, virDomainXMLOptionPtr xmlopt, virDomainDe }

/* Get final VMX output */ - if (virBufferError(&buffer)) { - virReportOOMError(); + if (virBufferError(&buffer))

virBufferError isn't adapted to report errors, thus this hunk would remove the error. NACK to this hunk.

goto cleanup; - }

vmx = virBufferContentAndReset(&buffer);

ACK to the rest of this patch. Peter